fix(jenkins): mark builds processed when fastforwarding #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two main changes here: 1. Add a metric for when we skip sending events (same as [`DockerMonitor`](https://github.com/spinnaker/igor/blob/master/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy#L155) 2. Mark the build processed even if we don't send an event to `echo` (because we are fastforwarding), again same as [`DockerMonitor`](https://github.com/spinnaker/igor/blob/master/igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy#L150) The idea behind #2 is that when we have two `igor`s: one actively sending events, the other just fast-forwarding to be ready to send events if needed. When we switch which `igor` triggers events to `echo`, we need to make sure we don't double trigger on builds in the past. Without this change, we would re-trigger the builds in the last few minutes due to cache being fast forwarded only when the running builds list is [empty](https://github.com/spinnaker/igor/blob/master/igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/JenkinsBuildMonitor.groovy#L209)
cfieber
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes here:
DockerMonitorecho(because we are fast-forwarding), again same asDockerMonitorThe idea behind #2 is that when we have two
igors: one actively sending events, the other just fast-forwarding to be ready to send events if needed.When we switch which
igortriggers events toecho, we need to make sure we don't double trigger on builds in the past. Without this change, we would re-trigger the builds in the last few minutes due to the cache being fast-forwarded only when the running builds list is empty