refactor(*): Replace Hystrix with Resilience4j #775
Conversation
| @@ -91,10 +90,7 @@ private String encode(String uri) { | |||
| } | |||
|
|
|||
| public ProjectsList getProjects() { | |||
There was a problem hiding this comment.
The grouppKey in here is a distinct name per jenkins host, so that we would stop requests to a bad jenkins master. I don't know that we actually get much benefit from tripping that circuit breaker when there are problems, but I wonder what still uses groupKey in here (and other spots that got de-hystrix'd)
There was a problem hiding this comment.
Just checked, groupKey isn't used anywhere else, I just failed to delete it.
I can add circuit breaking back into JenkinsService if we think it'd be useful. I suspect the only time it comes into play is when we take down a Jenkins master to upgrade - I think there's legitimacy there. WDYT?
There was a problem hiding this comment.
Added circuit breaking back in for jenkins.
| @@ -324,8 +310,9 @@ public Build getBuild(String repoSlug, int buildNumber) { | |||
| error -> { | |||
| log.warn("An error occurred while fetching new jobs from Travis.", error); | |||
| return Collections.emptyList(); | |||
There was a problem hiding this comment.
this seems like a pretty questionable fallback but I don't have skin in the Travis game so I'm not proposing we change anything
There was a problem hiding this comment.
It's the best fallback. Silent and sneaky!
But yeah, don't change it for now, but I'll try to remember to look into this.
robzienert
force-pushed
the
remove-hystrix
branch
from
c3aa55a
to
de54e85
Compare
robzienert
force-pushed
the
remove-hystrix
branch
from
de54e85
to
6371a17
Compare
Only one place where Hystrix was actually used for fallbacks, which I migrated. Everything else was just removed.