chore(*): Remove RxJava dependency from Igor #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jervi
force-pushed
the
remove_rxjava_dependency
branch
from
c25bd97
to
987eb9a
Compare
|
This is great! Do you know if there is already a If not, you can do something like There might be some other interesting options on TaskScheduler worth customizing in this case as well.. |
robzienert
reviewed
Jun 10, 2020
| @@ -2,9 +2,6 @@ dependencies { | |||
| implementation "com.netflix.spinnaker.kork:kork-artifacts" | |||
| implementation "com.netflix.spinnaker.kork:kork-core" | |||
|
|
|||
| // TODO(rz): Get rid of this dependency! | |||
| implementation "io.reactivex:rxjava" | |||
robzienert
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
This is lovely, thank you!
As for @cfieber's comment, there hasn't been TaskScheduler use before in Igor, so you should be good to add the customizer as he recommended.
|
I've added the pool size property 👍 Thanks for reviewing! |
I removed the two tests that focused only on the scheduler. I'll argue that they actually test the framework and not the code, and because there's nothing equivalent to RxJava's `TestScheduler` in Spring, I figured I'd just delete the whole thing.
jervi
force-pushed
the
remove_rxjava_dependency
branch
from
c657b32
to
f2cafce
Compare
cfieber
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the two test classes that focused only on the scheduler. I'll argue that they actually test the framework and not the code, and because there's nothing equivalent to RxJava's
TestSchedulerin Spring, I figured I'd just delete them.