fix(concourse): support old and new concourse auth (#762) #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(concourse): support old and new concourse auth Fixes concourse authentication for clusters >= v6.1.0 by detecting version and providing different implementation accordingly. Addresses issue: spinnaker/spinnaker#5797 * fix(concourse): support old and new concourse auth Sending basic auth header to /info endpoint causes 401 Addresses issue: spinnaker/spinnaker#5797 Co-authored-by: Jared Stehler <jared.stehler@edgenuity.com>
|
FYI @jaredstehler @kevinawoo manually cherry-picked this because mergify seems to be having issues |
kevinawoo
approved these changes
Jul 21, 2020
|
Please delete the pull request instructions from the body of your pull request message. The instructions start with the line:
You can reopen your pull request when this has been addressed. |
|
Fixed the branch protection to no longer expect a Travis build to pass and instead to only expect the Github Action build to pass. |
|
@Mergifyio refresh |
|
Command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes concourse authentication for clusters >= v6.1.0 by detecting version and providing different implementation accordingly.
Addresses issue: spinnaker/spinnaker#5797
Sending basic auth header to /info endpoint causes 401
Addresses issue: spinnaker/spinnaker#5797
Co-authored-by: Jared Stehler jared.stehler@edgenuity.com