Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(concourse): handle missing branch in git metadata #826

Merged
merged 2 commits into from
Jul 31, 2020
Merged

fix(concourse): handle missing branch in git metadata #826

merged 2 commits into from
Jul 31, 2020

Conversation

jaredstehler
Copy link
Contributor

Sets branch name to the sha1 short-ref if missing from concourse metadata

fixes spinnaker/spinnaker#5942

@jaredstehler
fix(concourse): handle missing branch in git metadata
bc9f7ad 
Sets branch name to the sha1 short-ref if missing from concourse metadata
gal-yardeni
gal-yardeni approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@gal-yardeni gal-yardeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix makes sense to me! thank you for fixing it and for describing the issue well!
Once you'll rebase it'll be ready for merge.

@jaredstehler
Copy link
Contributor Author

done

@gal-yardeni gal-yardeni added the ready to merge Approved and ready for merge label Jul 31, 2020
@mergify mergify bot merged commit 8eb26f9 into spinnaker:master Jul 31, 2020
@mergify mergify bot added the auto merged label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gal-yardeni gal-yardeni gal-yardeni approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle nullable branch name from concourse scm metadata
3 participants
@jaredstehler @gal-yardeni @spinnakerbot