feat(managed-delivery): Retrieve Managed Delivery manifests from GitHub #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side commit conventions here. |
kzwang
force-pushed
the
github-manifests
branch
from
6f7bcd6
to
50de015
Compare
gal-yardeni
reviewed
Aug 3, 2020
|
|
||
| /** | ||
| * Wrapper class for a collection of GitHub clients | ||
| */ | ||
| class GitHubMaster extends AbstractScmMaster { |
There was a problem hiding this comment.
since it's in OSS and we don't really know who is using this class, can it be backward-incompatible?
There was a problem hiding this comment.
The current GitHubMaster is just a copy of GitHubConfig, that defines the GitHubMaster bean, which is not used, and it didn't implement any methods from AbstractScmMaster, so shouldn't have backward compatibility issues.
|
@emjburns @luispollo appreciate if you could take a look whenever you can! |
luispollo
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for retrieving managed delivery manifests from GitHub repos.
Also fixed GitHub deprecated API authentication through query parameters (https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/)