chore(dockerMetadata): adding commit id, build number for docker images #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emjburns
reviewed
Sep 8, 2020
| @@ -199,7 +205,7 @@ class DockerMonitor extends CommonPollingMonitor<ImageDelta, DockerPollingDelta> | |||
| .version(image.tag) | |||
| .location(image.account) | |||
| .reference(imageId) | |||
| .metadata([fullname: imageReference, registry: image.account, tag: image.tag],) | |||
| .metadata([fullname: imageReference, registry: image.account, tag: image.tag, buildNumber: buildNumber, commitId: commitId],) | |||
There was a problem hiding this comment.
I think you should construct the metadata object up above, and then only add the build and commit data if it exists in the image data (just like for saving it in the clouddriver cache)
emjburns
reviewed
Sep 8, 2020
| @@ -125,6 +126,8 @@ class DockerMonitorSpec extends Specification { | |||
| assert artifacts.size() == 1 | |||
| assert artifacts[0].name == "repository" | |||
| assert artifacts[0].type == "DOCKER" | |||
| assert artifacts[0].metadata.buildNumber == "111" | |||
| assert artifacts[0].metadata.commitId == "ab12c3" | |||
There was a problem hiding this comment.
it might be good to have a test to make sure that the keys aren't present if the newt metadata doesn't exist
emjburns
reviewed
Sep 8, 2020
| assert artifacts[0].name == "repository" | ||
| assert artifacts[0].type == "DOCKER" | ||
| assert artifacts[0].metadata.tag == "new-tag" | ||
| assert artifacts[0].metadata.buildNumber == null |
There was a problem hiding this comment.
is there a way to assert the key isn't present instead?
There was a problem hiding this comment.
yep! changed to containsKey.
emjburns
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ֿ