Do not force nodeId configured when checking nexus webhook #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nodeId configured
|
hi @jmalvarezf-lmes! overall it looks good to me, any chance you can add a test for it? thanks! |
|
Hi @gal-yardeni! Sure, I'll do it tomorrow. Thanks, |
|
Test added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a problem that we do have with Nexus repositories. When you configure a nexus repository, right now you are forced to use nodeId, although it is optional, because when you configure webhooks in Nexus3, nodeId is always present. To allow this property to be really optional, we propose this PR, that checks previously if there are Nexus repositories configured with nodeId, and if there is none, check the repo name instead.
Hope you find it useful.