Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(retrofit): Use the retrofit log level bean from retrofit configuration in kork-web #894

Merged
merged 2 commits into from
Oct 16, 2020
Merged

fix(retrofit): Use the retrofit log level bean from retrofit configuration in kork-web #894

merged 2 commits into from
Oct 16, 2020

Conversation

marchello2000
Copy link
Contributor

Make it more consistent logging wise (echo client had logging set to NONE 😱 )

@ajordens
Copy link
Contributor

LGTM

@ajordens ajordens added the ready to merge Approved and ready for merge label Oct 16, 2020
@mergify mergify bot added the auto merged label Oct 16, 2020
@mergify mergify bot merged commit 0f72ac7 into spinnaker:master Oct 16, 2020
@marchello2000 marchello2000 deleted the mark/retrofit_logging branch October 16, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srekapalli srekapalli srekapalli approved these changes

@dreynaud dreynaud Awaiting requested review from dreynaud

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marchello2000 @ajordens @srekapalli @spinnakerbot