Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buildLog): adding build log hook #904

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

gal-yardeni
Copy link
Contributor

As a part of our effort to open source the CI view in Spinnaker, we have 2 endpoints which power this view:

  1. get all builds, based on a project and repo names.
  2. for each build, get the build log.

We already added the first hook (#1). This PR is adding the second hook to fetch the build log.
In order to use these hooks, you'll have to implement a CiBuildService in your igor fork, with concrete implementation to those two endpoints.

The CI view will call those endpoints from deck (the UI) via gate.

@gal-yardeni
Copy link
Contributor Author

cc: @emccallum

@gal-yardeni gal-yardeni added the ready to merge Approved and ready for merge label Dec 1, 2020
@mergify mergify bot merged commit b0cd43f into spinnaker:master Dec 1, 2020
@mergify mergify bot added the auto merged label Dec 1, 2020
@gal-yardeni gal-yardeni deleted the buildOutput branch December 1, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants