Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Fix outdated example in igor-config #920

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Jan 21, 2021

No description provided.

@gal-yardeni
Copy link
Contributor

@jervi can you elaborate a bit on why you changed it to 100? thanks!

@jervi
Copy link
Contributor Author

jervi commented Jan 27, 2021

I just updated it to reflect the default in Igor. The old numberOfRepositories setting is ignored by Igor - and did something else. It controlled how many recently built repos Igor would poll for changes (and it would then go on and poll each of these for recently built jobs). When I rewrote the Travis integration I opted to instead use another, simpler endpoint that just polls for recently built jobs across all repos - drastically reducing the number of requests to Travis. numberOfJobs controls how many jobs Travis should return per polling window.
https://github.com/spinnaker/igor/blob/master/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/config/TravisProperties.java#L62-L64

@gal-yardeni gal-yardeni added the ready to merge Approved and ready for merge label Jan 27, 2021
@mergify mergify bot merged commit fd0a0fb into spinnaker:master Jan 27, 2021
@mergify mergify bot added the auto merged label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants