-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CiBuild): extend Jenkins / Docker / Github clients with REST calls #929
Conversation
Just to clarify the purpose of this PR, the majority of the work here involves building hooks and adding REST calls that we use in the soon-to-be-released CiBuild plugin. The majority of the testing for the added functionality, we will add to the plugin. |
igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/JenkinsConfig.groovy
Show resolved
Hide resolved
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/client/GitHubMaster.groovy
Outdated
Show resolved
Hide resolved
igor-core/src/main/java/com/netflix/spinnaker/igor/build/model/GenericArtifact.java
Outdated
Show resolved
Hide resolved
Hi @nimakaviani. Just curious -- did you end up implementing an actual Spinnaker plugin for Igor as we had discussed? If there's code for it in GitHub already (even if not released yet), it might be helpful to link it in this PR for context. |
yes the plugin will be released here: https://github.com/nimakaviani/ci-build-plugin |
Hi @nimakaviani, can you give an example of the data that you need to pass is prompting this pr? It helps me to look at this pr with an actual example. Thanks! |
…ST calls - add extra necessary fields to Git and Build data structure for CiBuild support - add calls to jenkins and github to pull commit details and build info - add property field to enable CiBuild integration
- setting the url value for GenericArticact - simplified getCommitDetails code
Thanks @emjburns for taking the time. The PR only introduces some minor refactoring and adds a few setters and some extra retrofit rest calls to JenkinsClient and DockerClient, following the existing patterns. By data, do you mean the payload from the REST API endpoints for Jenkins and DockerHub? |
igor-core/src/main/java/com/netflix/spinnaker/igor/build/model/GenericGitRevision.java
Outdated
Show resolved
Hide resolved
igor-web/src/main/java/com/netflix/spinnaker/igor/scm/AbstractScmMaster.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have some minor comments regarding Lombok
igor-core/src/main/java/com/netflix/spinnaker/igor/build/model/GenericGitRevision.java
Outdated
Show resolved
Hide resolved
igor-core/src/main/java/com/netflix/spinnaker/igor/build/model/GenericBuild.java
Outdated
Show resolved
Hide resolved
igor-web/src/main/java/com/netflix/spinnaker/igor/scm/AbstractScmMaster.java
Show resolved
Hide resolved
igor-core/src/main/java/com/netflix/spinnaker/igor/build/model/GenericArtifact.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/cc @luispollo
/cc @gal-yardeni