Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CiBuild): extend Jenkins / Docker / Github clients with REST calls #929

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

nimakaviani
Copy link
Member

  • add extra necessary fields to Git and Build data structure for CiBuild support
  • add calls to jenkins and github to pull commit details and build info
  • add property field to enable CiBuild integration

/cc @luispollo
/cc @gal-yardeni

@nimakaviani
Copy link
Member Author

Just to clarify the purpose of this PR, the majority of the work here involves building hooks and adding REST calls that we use in the soon-to-be-released CiBuild plugin. The majority of the testing for the added functionality, we will add to the plugin.

@luispollo
Copy link
Contributor

Just to clarify the purpose of this PR, the majority of the work here involves building hooks and adding REST calls that we use in the soon-to-be-released CiBuild plugin. The majority of the testing for the added functionality, we will add to the plugin.

Hi @nimakaviani. Just curious -- did you end up implementing an actual Spinnaker plugin for Igor as we had discussed? If there's code for it in GitHub already (even if not released yet), it might be helpful to link it in this PR for context.

@nimakaviani
Copy link
Member Author

yes the plugin will be released here: https://github.com/nimakaviani/ci-build-plugin

@emjburns
Copy link
Contributor

Hi @nimakaviani, can you give an example of the data that you need to pass is prompting this pr? It helps me to look at this pr with an actual example. Thanks!

…ST calls

- add extra necessary fields to Git and Build data structure for CiBuild support
- add calls to jenkins and github to pull commit details and build info
- add property field to enable CiBuild integration
- setting the url value for GenericArticact
- simplified getCommitDetails code
@nimakaviani
Copy link
Member Author

Thanks @emjburns for taking the time. The PR only introduces some minor refactoring and adds a few setters and some extra retrofit rest calls to JenkinsClient and DockerClient, following the existing patterns. By data, do you mean the payload from the REST API endpoints for Jenkins and DockerHub?

Copy link
Contributor

@jervi jervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have some minor comments regarding Lombok

Copy link
Contributor

@luispollo luispollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luispollo luispollo added the ready to merge Approved and ready for merge label Mar 17, 2021
@mergify mergify bot merged commit 074d9aa into spinnaker:master Mar 17, 2021
@mergify mergify bot added the auto merged label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants