Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gcb): Add support for cancelling GCB build #970

Merged
merged 4 commits into from
Feb 20, 2022
Merged

feat(gcb): Add support for cancelling GCB build #970

merged 4 commits into from
Feb 20, 2022

Conversation

sharvanath
Copy link
Contributor

No description provided.

@sharvanath sharvanath mentioned this pull request Nov 6, 2021
Closed
@sharvanath
Copy link
Contributor Author

sharvanath commented Nov 6, 2021 •
edited
Loading

@ezimanyi could you help take a look?

@mattgogerly
Copy link
Member

Are there any tests you can add for this?

@sharvanath
Copy link
Contributor Author

Are there any tests you can add for this?

@mattgogerly All the changes I made are in igor-web/src/main/java/com/netflix/spinnaker/igor/gcb/ I do not see any test coverage for this.

@mattgogerly
Copy link
Member

Are there any tests you can add for this?

@mattgogerly All the changes I made are in igor-web/src/main/java/com/netflix/spinnaker/igor/gcb/ I do not see any test coverage for this.

The existing tests are in the groovy directory

@sharvanath
Copy link
Contributor Author

sharvanath commented Jan 7, 2022 •
edited
Loading

Are there any tests you can add for this?

@mattgogerly All the changes I made are in igor-web/src/main/java/com/netflix/spinnaker/igor/gcb/ I do not see any test coverage for this.

The existing tests are in the groovy directory

@mattgogerly Added a test.

@sharvanath
Copy link
Contributor Author

@mattgogerly ping on this!

@mattgogerly
Copy link
Member

Sorry for the delay

@Mergifyio update

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Feb 20, 2022
@mergify mergify bot added the auto merged label Feb 20, 2022
@mergify mergify bot merged commit a924a43 into spinnaker:master Feb 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2022

@sharva-scio is not allowed to run commands

@sharvanath
Copy link
Contributor Author

Sorry for the delay

@Mergifyio update

Np, thanks for reviewing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgogerly mattgogerly mattgogerly approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharvanath @mattgogerly @spinnakerbot