Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(retrofit): move url attribute from SpinnakerHttpException to SpinnakerServerException #1110

Merged
merged 8 commits into from
Oct 29, 2023
Merged

feat(retrofit): move url attribute from SpinnakerHttpException to SpinnakerServerException #1110

merged 8 commits into from
Oct 29, 2023

Commits on Oct 28, 2023

  1. refactor(retrofit/test): cleanup tests in kork-retrofit 

    to use fluent assertions and other small tweaks
    @dbyron-sf
    dbyron-sf committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    7c9b572 View commit details
    Browse the repository at this point in the history

  2. test(retrofit): add assertions on SpinnakerHttpException's url 

    to prepare to move url to SpinnakerServerException
    @dbyron-sf
    dbyron-sf committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    b212235 View commit details
    Browse the repository at this point in the history

  3. refactor(retrofit/test): remove duplicate test from SpinnakerRetrofit… 

    …2ErrorHandleTest

testRetrofitSimpleSpinnakerServerException actually generates a SpinnakerNetworkException and so it's effectively the same test as testRetrofitSimpleSpinnakerNetworkException.
    @dbyron-sf
    dbyron-sf committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    660c79b View commit details
    Browse the repository at this point in the history

  4. test(retrofit): test behavior when a retrofit endpoint generates a Sp… 

    …innakerNetworkException
    @dbyron-sf
    dbyron-sf committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    2fdbee3 View commit details
    Browse the repository at this point in the history

  5. feat(retrofit): move url attribute from SpinnakerHttpException to Spi… 

    …nnakerServerException

so it's available to exception handling code that currently has access to the url via RetrofitError.
    @dbyron-sf
    dbyron-sf committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    8eac81a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. refactor(retrofit): change Spinnaker*Exception constructors to take a… 

    … Request

instead of a url, to pave the way for storing other attributes of requests (e.g. the http request method)
    @dbyron-sf
    dbyron-sf committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    669d649 View commit details
    Browse the repository at this point in the history

  2. fix(retrofit): add javadoc, and properly set retryable to false in th… 

    …e new SpinnakerConversionException constructors
    @dbyron-sf
    dbyron-sf committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f4bb645 View commit details
    Browse the repository at this point in the history

  3. refactor(retrofit): use @getter for url in SpinnakerServerException

    @dbyron-sf
    dbyron-sf committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    64f7673 View commit details
    Browse the repository at this point in the history