feat(orca-bakery/manfests): add helmfile support #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thameezb
force-pushed
the
feat-6837/addHelmfileTemplatingEngine
branch
from
6f34e67
to
32cc807
Compare
thameezb
force-pushed
the
feat-6837/addHelmfileTemplatingEngine
branch
from
32cc807
to
9db2d36
Compare
|
SO minor, but some tests please would be nice :) I'd not expect huge tests, just a few to verify some of these |
Hey @jasonmcintosh I have added in some tests which covers most of |
.../src/main/java/com/netflix/spinnaker/orca/bakery/tasks/manifests/CreateBakeManifestTask.java
Outdated
Show resolved
Hide resolved
jasonmcintosh
approved these changes
Jul 19, 2023
|
@jasonmcintosh big thanks 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to spinnaker/spinnaker#6837
Adds in support for helmfile as a "Render Engine" in the "Bake (Manifest)" stage.
Relies on spinnaker/rosco#986