test(core): add tests to verify the rosco startup with various cloud providers enabled #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Feb 26, 2024
|
|
||
| @Test | ||
| public void startupTest() { | ||
| assert awsBakeHandler |
There was a problem hiding this comment.
Can you explain why this is a good startup test? Also, I'd rather see a more test-y assertion, like:
Suggested change
| assert awsBakeHandler | |
| assertThat(awsBakeHandler.getMaskedPackerParameters().toString()).isEqualToIgnoringCase("[aws_access_key, aws_secret_key]"); |
or even better:
assertThat(awsBakeHandler.getMaskedPackerParameters()).isEqualTo(List.of("aws_access_key", "aws_secret_key"));
There was a problem hiding this comment.
Used it as an additional marker to verify the values returned from the static class. However, it would not be required because the test is to verify the startup of rosco application with AWS provider enabled. So, removing this assert statement.
…providers enabled Adding tests for AWS, Azure, Docker, Google and Oracle cloud providers to verify the rosco startup with these providers enabled.
j-sandy
force-pushed
the
startup-test
branch
from
f103afa
to
0b85879
Compare
dbyron-sf
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for AWS, Azure, Docker, Google and Oracle cloud providers to verify the rosco startup with these providers enabled.