Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): replace groovy coordinates during upgrade of groovy 4.x #1107

Closed
wants to merge 1 commit into from

Commits on Sep 9, 2024

  1. refactor(dependency): replace groovy coordinates during upgrade of gr…

    …oovy 4.x
    
    Replacing the groovy coordinates from `org.codehaus.groovy` to `org.apache.groovy` supported by groovy 4.x and above versions.
    While upgrading groovy 4.0.15, encounter below error during build process of rosco-core module:
    ```
    startup failed:
    /rosco/rosco-core/src/main/groovy/com/netflix/spinnaker/rosco/api/BakeRequest.groovy: -1: Access to java.lang.Object#request_id is forbidden @ line -1, column -1.
    1 error
    
    > Task :rosco-core:compileGroovy FAILED
    ```
    In order to make `request_id` accessible, removed `final` access specifier and updated the deprecated `ApiModelProperty.readOnly()` method with `ApiModelProperty.AccessMode()` [method](https://docs.swagger.io/swagger-core/v1.5.X/apidocs/io/swagger/annotations/ApiModelProperty.html#readOnly()).
    j-sandy committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fd84dea View commit details
    Browse the repository at this point in the history