Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java17): conditional compilation to Java 17 bytecode #203

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

mattgogerly
Copy link
Member

Taking heavy inspiration from @plumpy (#149)

@mattgogerly mattgogerly force-pushed the feat/cross-compile branch 2 times, most recently from c945e96 to 54fef42 Compare November 30, 2023 09:02
@jasonmcintosh jasonmcintosh added the ready to merge ready to merge label Nov 30, 2023
@mattgogerly mattgogerly merged commit 8908eb8 into master Nov 30, 2023
2 checks passed
@mattgogerly mattgogerly deleted the feat/cross-compile branch November 30, 2023 15:36
@dbyron-sf
Copy link
Contributor

I'm a bit surprised this went in before we released 1.33...

@mattgogerly
Copy link
Member Author

I'm a bit surprised this went in before we released 1.33...

This doesn't actually do anything unless -PenableCrossCompilationPlugin=true is set on the build/targetJava17=true. I don't plan to merge those changes until 1.33 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants