-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split CI into separate moldy jobs #1192
Conversation
@@ -65,6 +55,60 @@ jobs: | |||
(cd pyvortex && uv run maturin develop) | |||
|
|||
(cd docs && uv run make html) | |||
|
|||
rust-docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weirdly the command pyvortex runs also does this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah make -C docs html
builds all the docs, including the Rust docs. We could add a different target like make -C docs full-html
and use that in docs.yml.
0493945
to
925b28c
Compare
.github/workflows/ci.yml
Outdated
steps: | ||
- uses: rui314/setup-mold@v1 | ||
- uses: actions/checkout@v4 | ||
- uses: ./.github/actions/cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run cleanup as the first thing in the job, otherwise it evicts installed binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also maybe we don't need it that much if we have separate jobs?
Ok @a10y I think we should change the cleanup job if we are splitting things, it's now taking close to 50% of the time. for some of them now. Could probably trim down the list. I went full hog trying to make sure we don't have to do a cleanup midway through |
Ok I've removed usage of |
looks like you do need some level of cleanup of hosted tools otherwise our builds step runs out of disk |
It was |
mold
linker for building Rust codeShaves ~40% off of CI times