feat: kleene_or, kleene_and, and restore SQL semantics #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that our row filters disagreed with DuckDB's semantics which is SQL semantics, in particular `where true or null` _keeps_ the row (we filtered it).
robert3005
reviewed
Nov 13, 2024
robert3005
reviewed
Nov 13, 2024
robert3005
reviewed
Nov 13, 2024
robert3005
approved these changes
Nov 13, 2024
|
There should be a place in RowFilter that needs changing as well? |
|
see: #1289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our row filters disagreed with DuckDB's semantics which is SQL semantics, in particular
where true or nullkeeps the row (we filtered it).cc: @robert3005 we'll probably conflict on #1272