SDK_READY missing condition

splitio · Sep 4, 2024 · f00bfb6 · f00bfb6
1 parent 0e18d36
commit f00bfb6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/build.gradle b/build.gradle
@@ -17,7 +17,7 @@ apply plugin: 'kotlin-android'
 apply from: 'spec.gradle'
 
 ext {
-    splitVersion = '4.3.0-alpha.3'
+    splitVersion = '4.3.0-alpha.4'
 }
 
 android {

diff --git a/src/main/java/io/split/android/client/events/SplitEventsManager.java b/src/main/java/io/split/android/client/events/SplitEventsManager.java
@@ -95,6 +95,7 @@ public void notifyInternalEvent(SplitInternalEvent internalEvent) {
             return;
         }
         try {
+            Logger.v("Internal event: " + internalEvent.name());
             mQueue.add(internalEvent);
         } catch (IllegalStateException e) {
             Logger.d("Internal events queue is full");
@@ -188,7 +189,7 @@ private boolean isTriggered(SplitEvent event) {
     }
 
     private void triggerSdkReadyIfNeeded() {
-        if ((wasTriggered(SplitInternalEvent.MY_SEGMENTS_UPDATED) || wasTriggered(SplitInternalEvent.MY_SEGMENTS_FETCHED)) &&
+        if ((wasTriggered(SplitInternalEvent.MY_SEGMENTS_UPDATED) || wasTriggered(SplitInternalEvent.MY_SEGMENTS_FETCHED) || wasTriggered(SplitInternalEvent.MY_LARGE_SEGMENTS_UPDATED)) &&
                 (wasTriggered(SplitInternalEvent.SPLITS_UPDATED) || wasTriggered(SplitInternalEvent.SPLITS_FETCHED)) &&
                 !isTriggered(SplitEvent.SDK_READY)) {
             trigger(SplitEvent.SDK_READY);

diff --git a/src/main/java/io/split/android/client/storage/mysegments/MySegmentsStorageImpl.java b/src/main/java/io/split/android/client/storage/mysegments/MySegmentsStorageImpl.java
@@ -14,7 +14,6 @@
 
 import io.split.android.client.dtos.Segment;
 import io.split.android.client.dtos.SegmentsChange;
-import io.split.android.client.utils.logger.Logger;
 
 class MySegmentsStorageImpl implements MySegmentsStorage {
 

diff --git a/...in/java/io/split/android/client/storage/mysegments/SqLitePersistentMySegmentsStorage.java b/...in/java/io/split/android/client/storage/mysegments/SqLitePersistentMySegmentsStorage.java
@@ -67,12 +67,8 @@ private SegmentsChange getMySegmentsFromEntity(SegmentEntity entity) {
             return createEmpty();
         }
 
-        SegmentsChange dto;
         try {
-            dto = Json.fromJson(storedJson, SegmentsChange.class);
-
-            Logger.v("Returning segments from DTO");
-            return dto;
+            return Json.fromJson(storedJson, SegmentsChange.class);
         } catch (JsonParseException | NullPointerException ex) {
             Logger.v("Parsing of segments DTO failed, returning as legacy");
             String[] segments = storedJson.split(",");