Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets evaluation tests #540

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Sets evaluation tests #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ecc1a5
Sets evaluation test
gthea Sep 12, 2023
e59ed36
Merge branch 'SDKS-7478_1' into SDKS-7478_2
gthea Sep 12, 2023
a3f4925
Merge branch 'SDKS-7478_1' into SDKS-7478_2
gthea Sep 13, 2023
7c8cc4d
Merge branch 'SDKS-7478_1' into SDKS-7478_2
gthea Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 172 additions & 0 deletions src/androidTest/java/tests/integration/sets/FlagSetsEvaluationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
package tests.integration.sets;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static helper.IntegrationHelper.ResponseClosure.getSinceFromUri;

import android.content.Context;

import androidx.test.platform.app.InstrumentationRegistry;

import org.junit.Before;
import org.junit.Test;

import java.io.IOException;
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;

import fake.HttpClientMock;
import fake.HttpResponseMock;
import fake.HttpResponseMockDispatcher;
import helper.DatabaseHelper;
import helper.FileHelper;
import helper.IntegrationHelper;
import helper.TestableSplitConfigBuilder;
import io.split.android.client.SplitClient;
import io.split.android.client.SplitClientConfig;
import io.split.android.client.SplitFactory;
import io.split.android.client.SplitFilter;
import io.split.android.client.SplitResult;
import io.split.android.client.SyncConfig;
import io.split.android.client.dtos.SplitChange;
import io.split.android.client.events.SplitEvent;
import io.split.android.client.storage.db.SplitRoomDatabase;
import io.split.android.client.utils.Json;
import tests.integration.shared.TestingHelper;

public class FlagSetsEvaluationTest {

private final FileHelper fileHelper = new FileHelper();
private final Context mContext = InstrumentationRegistry.getInstrumentation().getContext();

@Test
public void sdkWithSetsCanOnlyEvaluateSetsConfigured() throws IOException, InterruptedException {
/*
Initialize with set_1 configured. Changes contains 1 flag in set_1 & set_2, and one in set_3.

Only the flag in set_1 can be evaluated.
*/
SplitClient client = getClient(mContext, DatabaseHelper.getTestDatabase(mContext), "set_1");

Map<String, String> set1Treatments = client.getTreatmentsByFlagSet("set_1", null);
Map<String, String> set2Treatments = client.getTreatmentsByFlagSet("set_2", null);
Map<String, String> set3Treatments = client.getTreatmentsByFlagSet("set_3", null);
Map<String, SplitResult> set1Results = client.getTreatmentsWithConfigByFlagSet("set_1", null);
Map<String, SplitResult> set2Results = client.getTreatmentsWithConfigByFlagSet("set_2", null);
Map<String, SplitResult> set3Results = client.getTreatmentsWithConfigByFlagSet("set_3", null);
Map<String, String> allTreatments = client.getTreatmentsByFlagSets(Arrays.asList("set_1", "set_2", "set_3"), null);
Map<String, SplitResult> allTreatmentsWithConfig = client.getTreatmentsWithConfigByFlagSets(Arrays.asList("set_1", "set_2", "set_3"), null);

assertEquals(1, set1Treatments.size());
assertEquals(0, set2Treatments.size());
assertEquals(0, set3Treatments.size());
assertEquals(1, set1Results.size());
assertEquals(0, set2Results.size());
assertEquals(0, set3Results.size());
assertEquals(1, allTreatments.size());
assertEquals(1, allTreatmentsWithConfig.size());
assertTrue(set1Treatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(set1Results.values().stream().noneMatch(t -> t.treatment().equals("control")));
assertTrue(allTreatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(allTreatmentsWithConfig.values().stream().noneMatch(t -> t.treatment().equals("control")));
}

@Test
public void sdkWithoutSetsCanEvaluateAnySet() throws IOException, InterruptedException {
/*
Initialize with no sets configured. Changes contains 1 flag in set_1 & set_2, and one in set_3.

All flags can be evaluated by sets.
*/
SplitClient client = getClient(mContext, DatabaseHelper.getTestDatabase(mContext));

Map<String, String> set1Treatments = client.getTreatmentsByFlagSet("set_1", null);
Map<String, String> set2Treatments = client.getTreatmentsByFlagSet("set_2", null);
Map<String, String> set3Treatments = client.getTreatmentsByFlagSet("set_3", null);
Map<String, SplitResult> set1Results = client.getTreatmentsWithConfigByFlagSet("set_1", null);
Map<String, SplitResult> set2Results = client.getTreatmentsWithConfigByFlagSet("set_2", null);
Map<String, SplitResult> set3Results = client.getTreatmentsWithConfigByFlagSet("set_3", null);
Map<String, String> allTreatments = client.getTreatmentsByFlagSets(Arrays.asList("set_1", "set_2", "set_3"), null);
Map<String, SplitResult> allTreatmentsWithConfig = client.getTreatmentsWithConfigByFlagSets(Arrays.asList("set_1", "set_2", "set_3"), null);

assertEquals(1, set1Treatments.size());
assertEquals(1, set2Treatments.size());
assertEquals(1, set3Treatments.size());
assertEquals(1, set1Results.size());
assertEquals(1, set2Results.size());
assertEquals(1, set3Results.size());
assertTrue(set1Treatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(set2Treatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(set3Treatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(set1Results.values().stream().noneMatch(t -> t.treatment().equals("control")));
assertTrue(set2Results.values().stream().noneMatch(t -> t.treatment().equals("control")));
assertTrue(set3Results.values().stream().noneMatch(t -> t.treatment().equals("control")));
assertTrue(allTreatments.values().stream().noneMatch(t -> t.equals("control")));
assertTrue(allTreatmentsWithConfig.values().stream().noneMatch(t -> t.treatment().equals("control")));
}

private SplitClient getClient(
Context mContext,
SplitRoomDatabase splitRoomDatabase,
String... sets) throws IOException, InterruptedException {
SplitClientConfig config = new TestableSplitConfigBuilder()
.ready(30000)
.trafficType("client")
.enableDebug()
.impressionsRefreshRate(1000)
.impressionsCountersRefreshRate(1000)
.syncConfig(SyncConfig.builder()
.addSplitFilter(SplitFilter.bySet(Arrays.asList(sets)))
.build())
.featuresRefreshRate(2)
.streamingEnabled(false)
.eventFlushInterval(1000)
.build();

Map<String, IntegrationHelper.ResponseClosure> responses = new HashMap<>();
responses.put("splitChanges", (uri, httpMethod, body) -> {
String since = getSinceFromUri(uri);

if (since.equals("-1")) {
return new HttpResponseMock(200, loadSplitChangeWithSet(2));
} else {
return new HttpResponseMock(200, IntegrationHelper.emptySplitChanges(1602796638344L, 1602796638344L));
}
});

responses.put("mySegments/CUSTOMER_ID", (uri, httpMethod, body) -> new HttpResponseMock(200, IntegrationHelper.emptyMySegments()));

HttpResponseMockDispatcher httpResponseMockDispatcher = IntegrationHelper.buildDispatcher(responses);

SplitFactory factory = IntegrationHelper.buildFactory(
IntegrationHelper.dummyApiKey(),
IntegrationHelper.dummyUserKey(),
config,
mContext,
new HttpClientMock(httpResponseMockDispatcher),
splitRoomDatabase, null, null, null);

CountDownLatch readyLatch = new CountDownLatch(1);
SplitClient client = factory.client();
client.on(SplitEvent.SDK_READY, TestingHelper.testTask(readyLatch));

boolean readyAwait = readyLatch.await(5, TimeUnit.SECONDS);

if (readyAwait) {
return client;
} else {
return null;
}
}

private String loadSplitChangeWithSet(int setsCount) {
String change = fileHelper.loadFileContent(mContext, "split_changes_flag_set-" + setsCount + ".json");
SplitChange parsedChange = Json.fromJson(change, SplitChange.class);
parsedChange.since = parsedChange.till;

return Json.toJson(parsedChange);
}
}
13 changes: 5 additions & 8 deletions src/androidTest/java/tests/integration/sets/FlagSetsPollingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import java.util.Map;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;

import fake.HttpClientMock;
import fake.HttpResponseMock;
Expand All @@ -28,14 +27,11 @@
import helper.FileHelper;
import helper.IntegrationHelper;
import helper.TestableSplitConfigBuilder;
import io.split.android.client.SplitClient;
import io.split.android.client.SplitClientConfig;
import io.split.android.client.SplitFactory;
import io.split.android.client.SplitFilter;
import io.split.android.client.SyncConfig;
import io.split.android.client.dtos.SplitChange;
import io.split.android.client.events.SplitEvent;
import io.split.android.client.events.SplitEventTask;
import io.split.android.client.storage.db.SplitEntity;
import io.split.android.client.storage.db.SplitRoomDatabase;
import io.split.android.client.utils.Json;
Expand Down Expand Up @@ -64,8 +60,9 @@ public void setUp() throws Exception {

@Test
public void featureFlagIsUpdatedAccordingToSetsWhenTheyAreConfigured() throws IOException, InterruptedException {

// 1. Initialize a factory with polling and sets set_1 & set_2 configured.
createFactory(mContext, mRoomDb, false, "set_1", "set_2");
createFactory(mContext, mRoomDb, "set_1", "set_2");

// 2. Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
// -> only one feature flag should be added
Expand Down Expand Up @@ -103,8 +100,9 @@ public void featureFlagIsUpdatedAccordingToSetsWhenTheyAreConfigured() throws IO

@Test
public void featureFlagSetsAreIgnoredWhenSetsAreNotConfigured() throws IOException, InterruptedException {

// 1. Initialize a factory with polling and sets set_1 & set_2 configured.
createFactory(mContext, mRoomDb, false);
createFactory(mContext, mRoomDb);

// 2. Receive split change with 1 split belonging to set_1 & set_2 and one belonging to set_3
// -> only one feature flag should be added
Expand Down Expand Up @@ -162,7 +160,6 @@ public void featureFlagSetsAreIgnoredWhenSetsAreNotConfigured() throws IOExcepti
private SplitFactory createFactory(
Context mContext,
SplitRoomDatabase splitRoomDatabase,
boolean streamingEnabled,
String... sets) throws IOException {
SplitClientConfig config = new TestableSplitConfigBuilder()
.ready(30000)
Expand All @@ -174,7 +171,7 @@ private SplitFactory createFactory(
.addSplitFilter(SplitFilter.bySet(Arrays.asList(sets)))
.build())
.featuresRefreshRate(2)
.streamingEnabled(streamingEnabled)
.streamingEnabled(false)
.eventFlushInterval(1000)
.build();

Expand Down