Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt flag names for deletion #705

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Encrypt flag names for deletion #705

merged 1 commit into from
Sep 23, 2024

Conversation

gthea
Copy link
Contributor

@gthea gthea commented Sep 23, 2024

Android SDK

What did you accomplish?

  • Names for flags to be deleted from persistent storage are processed by the cipher in order to match storage.
  • Added tests.

@gthea gthea self-assigned this Sep 23, 2024
@gthea gthea marked this pull request as ready for review September 23, 2024 19:11
@gthea gthea requested a review from a team as a code owner September 23, 2024 19:11
javrudsky
javrudsky approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gthea gthea merged commit 88a593c into development Sep 23, 2024
5 checks passed
@gthea gthea deleted the SDKS-8863 branch September 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees

@gthea gthea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthea @javrudsky