Rollout config #719
Merged
Rollout config #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
approved these changes
Dec 4, 2024
| @@ -11,6 +11,7 @@ public class ServiceConstants { | |||
| public static final long MIN_INITIAL_DELAY = 5L; | |||
| public static final int DEFAULT_RECORDS_PER_PUSH = 100; | |||
| public static final long DEFAULT_SPLITS_CACHE_EXPIRATION_IN_SECONDS = TimeUnit.DAYS.toSeconds(10); // 10 days | |||
There was a problem hiding this comment.
Are DEFAULT_SPLITS_CACHE_EXPIRATION_IN_SECONDS and DEFAULT_ROLLOUT_CACHE_EXPIRATION constants related? in that case, should we have only one, or derive one from the other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android SDK
What did you accomplish?