[SDKS-7563] Stabilize integration tests #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
requested changes
Sep 28, 2023
| @@ -503,10 +503,6 @@ export default function (fetchMock, assert) { | |||
| const client = splitio.client(); | |||
| const manager = splitio.manager(); | |||
|
|
|||
| client.once(client.Event.SDK_READY_FROM_CACHE, () => { | |||
There was a problem hiding this comment.
Rather than simply removing asserts, it is better to update them to keep information of the expected behaviour:
client.once(client.Event.SDK_READY_FROM_CACHE, () => {
t.fail('It should not emit SDK_READY_FROM_CACHE because ...');
t.end();
});
Idem for the other removed asserts.
There was a problem hiding this comment.
With this change, none of the tests below line 472 (/** Fetch specific splits **/) is asserting that the SDK_READY_FROM_CACHE event is emitted when using split filters.
So, I would create a new test for the following basic case:
assert.test(t => { // Testing when we start with cached data with split filter, and the same split filter is provided in the config
This should emit the event because the config has the same split filter as the one in the cache.
EmilianoSanchez
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Stabilize Integration tests for flag sets implementation
How do we test the changes introduced in this PR?
Extra Notes