[SDKS-7567] Add type definitions #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmelograno
approved these changes
Oct 10, 2023
EmilianoSanchez
requested changes
Oct 10, 2023
types/splitio.d.ts
Outdated
| @@ -1417,6 +1417,74 @@ declare namespace SplitIO { | |||
| * @returns {TreatmentsWithConfig} The map with all the TreatmentWithConfig objects | |||
| */ | |||
| getTreatmentsWithConfig(featureFlagNames: string[], attributes?: Attributes): TreatmentsWithConfig, | |||
| /** | |||
| * Returns a Treatments value, which is an object map with the treatments for the feature flags related to the given flagSet. | |||
There was a problem hiding this comment.
flagSet -> flag set
Check other occurrences if the term flagSet or flagSets in descriptive comments
| * @param {Attributes=} attributes - An object of type Attributes defining the attributes for the given key. | ||
| * @returns {Treatments} The map with all the TreatmentWithConfig objects | ||
| */ | ||
| getTreatmentsByFlagSet(key: SplitKey, flagSet: string, attributes?: Attributes): Treatments, |
added 2 commits
October 10, 2023 14:54
EmilianoSanchez
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes