Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flag sets] Input validation for getTreatments action creator #97

Merged
merged 21 commits into from
Dec 18, 2023
Merged

[Flag sets] Input validation for getTreatments action creator #97

merged 21 commits into from
Dec 18, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Dec 15, 2023 •
edited
Loading

Redux SDK

What did you accomplish?

  • Upgrade JS SDK to include flag sets support and other features.
  • Updated getTreatments action creator to validate the input param. If the param is invalid, no actions are dispatched. If both splitNames and flagSets are provided, it logs a warning and flagSets are ignored.

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review December 15, 2023 17:12
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner December 15, 2023 17:13
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@EmilianoSanchez EmilianoSanchez merged commit 8306c55 into development Dec 18, 2023
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the input_validation_for_getTreatments branch December 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmaz90 emmaz90 emmaz90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilianoSanchez @emmaz90