Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added iff compression and decoding message #473

Merged
merged 9 commits into from
Jun 5, 2023
Merged

added iff compression and decoding message #473

merged 9 commits into from
Jun 5, 2023

Conversation

chillaq
Copy link
Contributor

@chillaq chillaq commented May 31, 2023

Ruby SDK

What did you accomplish?

How to test new changes?

Extra Notes

@chillaq chillaq requested a review from sanzmauro May 31, 2023 15:28
sanzmauro
sanzmauro requested changes May 31, 2023
View reviewed changes
lib/splitclient-rb/sse/notification_processor.rb Outdated Show resolved Hide resolved
lib/splitclient-rb/sse/workers/splits_worker.rb Outdated Show resolved Hide resolved
lib/splitclient-rb/sse/workers/splits_worker.rb Outdated Show resolved Hide resolved
@chillaq chillaq requested a review from sanzmauro May 31, 2023 15:58
@sanzmauro
Copy link
Contributor

I pull your changes and i am getting the following error:

➜  ruby-client git:(iff-update-splitworker) bundle exec rspec

An error occurred while loading ./spec/sse/workers/splits_worker_spec.rb. - Did you mean?
                    rspec ./spec/sse/workers/segments_worker_spec.rb

Failure/Error: require 'byebug'

You are missing to add the development dependency in .gemspec

@chillaq chillaq requested a review from sanzmauro June 5, 2023 15:20
@chillaq chillaq merged commit 4c12107 into Feature/IFF Jun 5, 2023
@chillaq chillaq deleted the iff-update-splitworker branch June 5, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillaq @sanzmauro