added flag_set_filter config param and validation #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanzmauro
reviewed
Oct 24, 2023
| return nil | ||
| end | ||
| valid_flag_sets = SortedSet[] | ||
| flag_sets.compact.uniq.select do |flag_set| |
There was a problem hiding this comment.
you are not trimming the flag set if neecessary.
There was a problem hiding this comment.
The trimming is done inside the loop, I need to check first if the object is string, otherwise the strip method will raise exception
sanzmauro
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby SDK
What did you accomplish?
How to test new changes?
Extra Notes