Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client class and fixed tests #488

Merged
merged 3 commits into from
Nov 10, 2023
Merged

update client class and fixed tests #488

merged 3 commits into from
Nov 10, 2023

Conversation

chillaq
Copy link
Contributor

@chillaq chillaq commented Nov 3, 2023

Ruby SDK

What did you accomplish?

How to test new changes?

Extra Notes

@chillaq chillaq requested a review from a team as a code owner November 3, 2023 15:50
sanzmauro
sanzmauro requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@sanzmauro sanzmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test for:

  • flag_set_filter.rb
  • flag_sets_repository.rb
  • repository_helper.rb

lib/splitclient-rb/cache/repositories/splits_repository.rb Outdated Show resolved Hide resolved
lib/splitclient-rb/cache/repositories/splits_repository.rb Outdated Show resolved Hide resolved
lib/splitclient-rb/helpers/repository_helper.rb Show resolved Hide resolved
@chillaq chillaq merged commit 27af19d into Feature/FlagSets Nov 10, 2023
@chillaq chillaq deleted the flagset-client-splitclient branch November 10, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillaq @sanzmauro