Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to remove dead socket on startup #14

Merged
merged 6 commits into from
Nov 10, 2023
Merged

attempt to remove dead socket on startup #14

merged 6 commits into from
Nov 10, 2023

Conversation

mredolatti
Copy link
Contributor

No description provided.

mmelograno
mmelograno previously approved these changes Nov 1, 2023
View reviewed changes
mmelograno
mmelograno previously approved these changes Nov 8, 2023
View reviewed changes
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 48.1% 48.1% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@mredolatti mredolatti merged commit 1608e5e into main Nov 10, 2023
2 of 3 checks passed
@mredolatti mredolatti deleted the enh/dead_socket_removal_attempt branch November 10, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmayorsplit nmayorsplit nmayorsplit approved these changes

@mmelograno mmelograno mmelograno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mredolatti @mmelograno @nmayorsplit