feat: extend events_ingested to accommodate UCC health check page #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
requested changes
Apr 18, 2024
solnlib/log.py
Outdated
| result["event_account"] = account | ||
| if host: | ||
| result["event_host"] = host | ||
| if "://" in modular_input_name: |
There was a problem hiding this comment.
Can we specify the format in the doc-string and throw a ValueError exception if the format is not what we expect?
There was a problem hiding this comment.
I didn't want to force users to use specific format, because someone may already be using this function and will want it to stay as it is
artemrys
changed the title
artemrys
approved these changes
Apr 19, 2024
|
🎉 This PR is included in version 4.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the
events_ingestedfunction to log more information such as index, host, account and input.