Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check before truncating new line #107

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

hetangmodi-crest
Copy link
Contributor

Fix: updated the logic to remove duplicate newlines only when there is content (default stanzas and others) as they are adding two new lines.
Test: added test cases for all the scenarios based on the write() function.

@hetangmodi-crest hetangmodi-crest added the bug Something isn't working label Aug 12, 2024
@hetangmodi-crest hetangmodi-crest self-assigned this Aug 12, 2024
@artemrys artemrys merged commit 1736d97 into main Aug 13, 2024
12 checks passed
@artemrys artemrys deleted the fix/truncating-trailing-newline branch August 13, 2024 08:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 0.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants