-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: publish conditions #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkolasinski-splunk
force-pushed
the
fix/publish-conditions
branch
from
September 25, 2024 11:27
7f1f53c
to
42dfa70
Compare
mkolasinski-splunk
force-pushed
the
fix/publish-conditions
branch
from
September 25, 2024 11:41
42dfa70
to
272b4f9
Compare
mbruzda-splunk
previously approved these changes
Sep 25, 2024
Co-authored-by: kdoroszko-splunk <kdoroszko@splunk.com>
mkolasinski-splunk
requested review from
kdoroszko-splunk and
mbruzda-splunk
September 26, 2024 07:04
kdoroszko-splunk
approved these changes
Sep 26, 2024
🎉 This PR is included in version 4.17.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where automated releases where not created due to incorrect conditions for pre-publish job.
Tests:
PR scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/11027730555
release scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/11028553116
custom version release: https://github.com/splunk/test-addonfactory-repo/actions/runs/11047251558