Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish conditions #339

Merged
merged 3 commits into from
Sep 26, 2024
Merged

fix: publish conditions #339

merged 3 commits into from
Sep 26, 2024

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Sep 25, 2024

Fix the issue where automated releases where not created due to incorrect conditions for pre-publish job.

Tests:
PR scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/11027730555
release scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/11028553116
custom version release: https://github.com/splunk/test-addonfactory-repo/actions/runs/11047251558

@mkolasinski-splunk mkolasinski-splunk marked this pull request as ready for review September 25, 2024 11:28
@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner September 25, 2024 11:28
@mkolasinski-splunk mkolasinski-splunk changed the base branch from develop to main September 25, 2024 11:40
mbruzda-splunk
mbruzda-splunk previously approved these changes Sep 25, 2024
Co-authored-by: kdoroszko-splunk <kdoroszko@splunk.com>
@mkolasinski-splunk mkolasinski-splunk merged commit 329c01e into main Sep 26, 2024
6 checks passed
@mkolasinski-splunk mkolasinski-splunk deleted the fix/publish-conditions branch September 26, 2024 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.17.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants