Take 2: Splunkbase download updates courtext res260 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork at all. Fixes splunk#295.
…shed when specifying a `detection.tags.asset_type`. Fixes splunk#313.
Do not serialize TestApp.hardcoded_path if it has value None. Fixes #…
Fix a bug where the jinja template for `analyticsories_detection` cra…
add azure-pipelines.yml
fix azure-pipelines.yml
fix build
fix build
fix build
…password to be specified w... Allow test.splunk_api_username and test.splunk_api_password to be specified with environment variables SPLUNKBASE_USERNAME and SPLUNKBASE_PASSWORD to avoid putting credentials in YAML files.
Do not serialize TestApp.hardcoded_path if it has value None. Fixes #…
Fix a bug where App_Base.getSplunkbasePath() was broken and did not w…
…base. Fix du setup initial + téléchargement depuis splunkbase.
fix typo
fix tests maybe
…or tests Add support for dynamically creating custom_index for tests
Fix validation for apps
- Bugfix: add a setup step for `contentctl test`: `wait_for_app_installation`. This step ensures that the required apps are correctly installed AND configured (for splunk ES) - Bugfix: add a 20 secs sleep after starting the container in `contentctl test` to ensure Docker has the time to map the ports correctly before contentctl attempts to connect. This was problematic on Windows with WSL. - Bugfix: Fix path to download apps from SplunkBase - Bugfix: Fix a bug where `contentctl validate` and `contentctl build` needed the splunkbase creds to work, which made no sense. - Fix typo - Feature: Introduction of a logger object in the hope of gradually replacing usage of `print()` statements - Feature: `contentctl test` now creates missing indexes specified in test data as `custom_index` - Change: Send tests data to the HEC as text and not binary - Change: Add a message that makes debugging failed tests easier.
|
I will merge with main to make sure nothing breaks with the latest changes on main. |
Thank you, this is great and very helpful. I will deprecate that other PR and take a look at this one! |
|
I merged with main, ran my manual tests, everything is working fine on my end! |
|
@Res260 , still working on review this in prep for an upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically all the changes our private fork have at the moment.
Here is what it includes:
contentctl test:wait_for_app_installation. This step ensures that the required apps are correctly installed AND configured (for splunk ES)contentctl testto ensure Docker has the time to map the ports correctly before contentctl attempts to connect. This was problematic on Windows with WSL.contentctl validateandcontentctl buildneeded the splunkbase creds to work, which made no sense.print()statementscontentctl testnow creates missing indexes specified in test data ascustom_indexFixes #319
Fixes #295
Fixes #321
@pyth0n1c So sorry to open a new PR, but this was the only way for me to contribute without having to send patch files like a caveman. We should close #322 and use this PR as well. It includes a lot of changes, but I think they are all changes worthy to be included upstream and fixes weird bugs regarding using
contentctl teston Windows and downloading apps from SplunkBase.