Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secret Scanning to Alert Overview #37

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

leftrightleft
Copy link
Collaborator

What's changed

This change introduces the secret scanning alerts to the security alert overview page.
This change fixes #36

@leftrightleft
Copy link
Collaborator Author

@derkkila @derkkila-splunk (Sorry, don't know which one is the real Doug)
Can I get some 👀 on this change? Specifically, the root search. It's quite a bit different from the past. I want to make sure I'm not missing something here.

@@ -244,7 +251,7 @@
<option name="totalsRow">false</option>
<option name="wrap">true</option>
<format type="color" field="severity">
<colorPalette type="map">{"critical":#DC4E41,"high":#F1813F,"moderate":#F8BE34}</colorPalette>
<colorPalette type="map">{"critical":#DC4E41,"high":#F1813F,"moderate":#F8BE34, "medium":#F8BE34}</colorPalette>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding medium to the color list. Dependabot and Code Scanning have different levels of severity.

@derkkila-splunk derkkila-splunk merged commit 44e0bbf into splunk:main Apr 19, 2022
akinnane added a commit to akinnane/github_app_for_splunk that referenced this pull request Mar 10, 2023
Narrow CodeScanning eventtype definition.

In PR splunk#35 @leftrightleft narrowed the eventtype for CodeScanning events but then was (accidently?) reverted by splunk#37. This change narrows the eventtype again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Secret Scanning alerts to alert overview page
2 participants