Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle other type of truststore #350

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Handle other type of truststore #350

merged 1 commit into from
Aug 29, 2022

Conversation

zigarn
Copy link
Contributor

@zigarn zigarn commented Aug 1, 2022

Only the discouraged JKS was available

@zigarn
Copy link
Contributor Author

zigarn commented Aug 1, 2022

Sadly, use of secrets is breaking the CI when source branch is from a fork:

@zigarn
Copy link
Contributor Author

zigarn commented Aug 2, 2022 •
edited
Loading

The GitHub workflow should be changed to be triggered on pull_request_target (cf. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target):

kafka-connect-splunk/.github/workflows/ci_build_test.yaml

Line 4 in 4bc5586

pull_request:

@foram-splunk
Copy link
Contributor

Hi @zigarn, I've updated the workflow.

Can you please rebase this PR?

@zigarn
Handle other type of truststore
30625e3 
Only the discouraged JKS was available
@zigarn zigarn temporarily deployed to workflow-approval August 17, 2022 11:30 Inactive
@zigarn
Copy link
Contributor Author

zigarn commented Aug 17, 2022

@foram-splunk: thanks for updating the workflow. PR rebased and workflow waiting for approval.

@github-actions
Copy link

Unit Test Results

152 tests   152 ✔️  37s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit 30625e3.

@zigarn zigarn temporarily deployed to workflow-approval August 23, 2022 06:57 Inactive
@foram-splunk foram-splunk self-requested a review August 23, 2022 07:13
@foram-splunk foram-splunk merged commit 9dc0c0b into splunk:develop Aug 29, 2022
@zigarn zigarn deleted the truststore-type branch August 29, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foram-splunk foram-splunk foram-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigarn @foram-splunk