fix: ADDON-66599 deprecate splunk-hec-token default value and break test execution on exception #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est execution on exception (#804) - deprecate default value of splunk-hec-token - give a warning when it's used - add console handler to logger - warnings and errors beside being logged to pytest_splunk_addon.log are also logged to console - other minor refactors from PR-803 References: https://splunk.atlassian.net/browse/ADDON-66599 https://github.com/splunk/pytest-splunk-addon/pull/803/files --------- Co-authored-by: Artem Rys <rysartem@gmail.com>
mbruzda-splunk
approved these changes
Dec 12, 2023
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Already released on develop and tested on couple of repos.
https://github.com/splunk/splunk-add-on-for-google-workspace/pull/515
References:
https://splunk.atlassian.net/browse/ADDON-66599
https://github.com/splunk/pytest-splunk-addon/pull/803/files