Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating network resolution data model #840

Merged
merged 3 commits into from
May 16, 2024

Conversation

harshilgajera-crest
Copy link
Contributor

@harshilgajera-crest harshilgajera-crest commented May 15, 2024

Added all the values for record_type field as per IANA website for network resolution data model.

@harshilgajera-crest harshilgajera-crest changed the title updating network resolution data model chore: updating network resolution data model May 15, 2024
@harshilgajera-crest harshilgajera-crest marked this pull request as ready for review May 15, 2024 12:02
@harshilgajera-crest harshilgajera-crest requested review from a team as code owners May 15, 2024 12:02
"TA",
"DLV",
"Private use",
"Reserved"
],
"comment": "The DNS resource record type. For details, see the List of DNS record types on Wikipedia."
Copy link

@alexeisuv alexeisuv May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on Wikipedia, but on the IANA web site.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@artemrys artemrys changed the base branch from main to develop May 16, 2024 08:13
@artemrys artemrys changed the title chore: updating network resolution data model feat: updating network resolution data model May 16, 2024
@artemrys artemrys merged commit b851bb9 into develop May 16, 2024
35 of 36 checks passed
@artemrys artemrys deleted the ci/updating_data_models branch May 16, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 5.4.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants