Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating src and dest fields #846

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

harshilgajera-crest
Copy link
Contributor

@harshilgajera-crest harshilgajera-crest commented May 28, 2024

Removing validations from dest and src as they can be any string.
Keeping corresponding validations for src_ip and dest_ip

@harshilgajera-crest harshilgajera-crest marked this pull request as ready for review May 28, 2024 13:22
@harshilgajera-crest harshilgajera-crest requested review from a team as code owners May 28, 2024 13:22
@artemrys
Copy link
Member

ci -> fix?

@harshilgajera-crest harshilgajera-crest changed the title ci: updating src and dest fields fix: updating src and dest fields May 28, 2024
@harshilgajera-crest
Copy link
Contributor Author

ci -> fix?

Updated

@artemrys artemrys merged commit a143c49 into develop May 29, 2024
34 of 35 checks passed
@artemrys artemrys deleted the ci/updating-data-models branch May 29, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.3.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 5.4.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants