Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requirement test generation #893

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

dvarasani-crest
Copy link
Contributor

@dvarasani-crest dvarasani-crest commented Oct 23, 2024

Fix the issue with requirement test generation.

  • Requirement test generation for "test_cim_fields_recommended" was failing for the sample event with only other_mappings and no cim mapping attached.

Updated e2e tests to cover this scenario as well.

@dvarasani-crest dvarasani-crest marked this pull request as ready for review October 23, 2024 13:03
@dvarasani-crest dvarasani-crest requested a review from a team as a code owner October 23, 2024 13:03
<field name="dest" value="so1" />
<field name="vendor_product" value="Pytest Splunk Addon"/>
</other_mappings>
</event>
</device>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add \n at EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dvarasani-crest dvarasani-crest merged commit 8d42cb6 into main Oct 28, 2024
21 of 22 checks passed
@dvarasani-crest dvarasani-crest deleted the fix/requirement-test-generation branch October 28, 2024 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants