Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRL-1746 macro ymls and detection update #406

Merged
merged 3 commits into from
Mar 16, 2020
Merged

CRL-1746 macro ymls and detection update #406

merged 3 commits into from
Mar 16, 2020

Conversation

patel-bhavin
Copy link
Contributor

Created macro files and update all searches listed in https://jira.splunk.com/browse/CRL-1746

@auto-assign auto-assign bot requested a review from josehelps March 10, 2020 00:48
@patel-bhavin patel-bhavin changed the title macro ymls and detection update CRL-1746 macro ymls and detection update Mar 16, 2020
@rvaldez617 rvaldez617 self-requested a review March 16, 2020 20:38
rvaldez617
rvaldez617 approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@rvaldez617 rvaldez617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - updates to include output filters, associated macro files, and version/mod_date as appropriate.

@rvaldez617 rvaldez617 merged commit 5e35219 into develop Mar 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the CRL-1746 branch March 16, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvaldez617 rvaldez617 rvaldez617 approved these changes

@josehelps josehelps Awaiting requested review from josehelps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patel-bhavin @rvaldez617