Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

feat: extract IF-MIB data from an SNMPWALK #96

Merged
merged 3 commits into from
Jul 22, 2021
Merged

feat: extract IF-MIB data from an SNMPWALK #96

merged 3 commits into from
Jul 22, 2021

Conversation

lstoppa
Copy link
Contributor

@lstoppa lstoppa commented Jul 22, 2021

No description provided.

@lstoppa
feat: initial support for parsing IF-MIB data
e10051f 
- added a basic support for extracting from an SNMP WALK:
  - the total number of network interfaces,
  - all indexes associated to each network interface
  - all interface names available
 - some unit-test added

 In this way, we have the basic information required for
 sending additional data to Splunk.
@lstoppa
feat: initial support for parsing IF-MIB data (ADDON-39612)
39fae8e 
- added a basic support for extracting from an SNMP WALK:
  - the total number of network interfaces,
  - all indexes associated to each network interface
  - all interface names available
 - some unit-test added

 In this way, we have the basic information required for
 sending additional data to Splunk.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lstoppa lstoppa changed the base branch from main to develop July 22, 2021 12:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #96 (4074212) into develop (f3081c1) will increase coverage by 7.27%.
The diff coverage is 92.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    33.06%   40.33%   +7.27%     
===========================================
  Files           19       22       +3     
  Lines          735      838     +103     
===========================================
+ Hits           243      338      +95     
- Misses         492      500       +8
Impacted Files Coverage Δ
tests/test_utils.py 60.00% <60.00%> (ø)
tests/test_interface_mib.py 97.56% <97.56%> (ø)
..._for_snmp_poller/manager/realtime/interface_mib.py 97.87% <97.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3081c1...4074212. Read the comment docs.

@lstoppa
Copy link
Contributor Author

lstoppa commented Jul 22, 2021

I have read the Code of Conduct and I hereby accept the Terms

@github-actions
Copy link
Contributor

Expected release notes (by @lstoppa)

features:
initial support for parsing IF-MIB data (ADDON-39612) - added a basic support for extracting from an SNMP WALK: - the total number of network interfaces, - all indexes associated to each network interface - all interface names available - some unit-test added (39fae8e)
initial support for parsing IF-MIB data - added a basic support for extracting from an SNMP WALK: - the total number of network interfaces, - all indexes associated to each network interface - all interface names available - some unit-test added (e10051f)
support polling the same IP address using multiple profiles (#92) (a6320ca)

fixes:
lint (ADDON-39612) (4074212)
forced commit for creating new release (f3081c1)

others (will not be included in Semantic-Release notes):
ebe3ebf Feature/redo walk (#95)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lstoppa lstoppa merged commit 7699591 into develop Jul 22, 2021
@lstoppa lstoppa deleted the feature/send_network_interface branch July 22, 2021 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.5.0-develop.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adriansudol adriansudol adriansudol approved these changes

@lingy1028 lingy1028 Awaiting requested review from lingy1028

@okuzhel okuzhel Awaiting requested review from okuzhel

@ryanfaircloth ryanfaircloth Awaiting requested review from ryanfaircloth

Assignees
No one assigned
Labels
released on @develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lstoppa @codecov-commenter @ryanfaircloth @adriansudol