Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-deploy-plugin is included as a transitive dependency in 1.7.1 #170

Closed
myuwono opened this issue Sep 2, 2021 · 2 comments
Closed

Comments

@myuwono
Copy link

myuwono commented Sep 2, 2021

Hi All,

I wonder if the inclusion of maven-deploy-plugin in the 1.7.1 release intended?

https://github.com/splunk/splunk-sdk-java/blob/master/pom.xml#L34-L39

We realized this because our security scanner picked that up in the deployment bundle. Right now we needed to explicitly exclude this in our pom, to prevent this from being included. i.e.

        <!-- Splunk -->
        <dependency>
            <groupId>com.splunk</groupId>
            <artifactId>splunk</artifactId>
            <version>1.7.1</version>
            <exclusions>
                <exclusion>
                    <groupId>org.apache.maven.plugins</groupId>
                    <artifactId>maven-deploy-plugin</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

Thanks!

@bparmar-splunk
Copy link
Contributor

Hi @myuwono,
Thanks for posting this.

Yes, it was intentionally kept earlier with regards to SDK v1.7.0, because we have skipped parent pom deployment and only deployment of splunk (child module) was targeted.
But in recent version (i.e. v1.7.1), we had deployed parent module, due to missing dependencies in child.

So as a part of next release, we are planning to add deploy plugin in parent and remove it from splunk module.

@bparmar-splunk
Copy link
Contributor

We have successfully released Java SDK new version 1.8.0.
This issue is already been part of this release.
Hence, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants