Deploy plugin is removed from splunk module.

[bparmar-splunk]

Update:

• Deploy plugin for splunk module removed and it will use its parent plugin for deployment. (Refer Issue maven-deploy-plugin is included as a transitive dependency in 1.7.1 #170 )
• Supporting comment has been added in examples/pom.xml file as we have skipped deployment there.

[fantavlik]

I don't believe this fixes the issues we saw with the 1.7.1 build (and future releases) if I understand the issue correctly. The overall project pom lists splunk/pom.xml as a dependency: https://github.com/splunk/splunk-sdk-java/blob/master/pom.xml#L16-L21 the splunk/pom.xml file (which has already been published here: https://splunk.jfrog.io/ui/repos/tree/PomView/ext-releases-local%2Fcom%2Fsplunk%2Fsplunk-sdk-java%2F1.0.0%2Fsplunk-sdk-java-1.0.0.pom) has a version associated with it already 1.7.1 (see line 9 of the link). Therefor, any versions published after 1.7.1 will continue to throw the same error that we saw when publishing 1.7.1 - similarly it's why version 1.7.0 is no longer working. In other words, I would expect even after these changes that we would release SDK version 1.7.2 but that it would refer to splunk-sdk-java version 1.0.0 which has a module version of 1.7.1, so I'd expect the same kind of error as we currently see with 1.7.0: > Could not resolve com.splunk:splunk:1.7.0. > inconsistent module metadata found. Descriptor: com.splunk:splunk:1.7.1 Errors: bad version: expected='1.7.0' found='1.7.1'

I will admit that I do not fully understand how parent/child .pom projects are intended to be setup but this doesn't seem to address the issue at first glance. Happy to discuss more if I'm misunderstanding the issue.

[bparmar-splunk]

I don't believe this fixes the issues we saw with the 1.7.1 build (and future releases) if I understand the issue correctly. The overall project pom lists splunk/pom.xml as a dependency: https://github.com/splunk/splunk-sdk-java/blob/master/pom.xml#L16-L21 the splunk/pom.xml file (which has already been published here: https://splunk.jfrog.io/ui/repos/tree/PomView/ext-releases-local%2Fcom%2Fsplunk%2Fsplunk-sdk-java%2F1.0.0%2Fsplunk-sdk-java-1.0.0.pom) has a version associated with it already 1.7.1 (see line 9 of the link). Therefor, any versions published after 1.7.1 will continue to throw the same error that we saw when publishing 1.7.1 - similarly it's why version 1.7.0 is no longer working. In other words, I would expect even after these changes that we would release SDK version 1.7.2 but that it would refer to splunk-sdk-java version 1.0.0 which has a module version of 1.7.1, so I'd expect the same kind of error as we currently see with 1.7.0: > Could not resolve com.splunk:splunk:1.7.0. > inconsistent module metadata found. Descriptor: com.splunk:splunk:1.7.1 Errors: bad version: expected='1.7.0' found='1.7.1'

I will admit that I do not fully understand how parent/child .pom projects are intended to be setup but this doesn't seem to address the issue at first glance. Happy to discuss more if I'm misunderstanding the issue.

Hi @fantavlik,
Let us discuss this further for more insights.
These changes will not cause any dependency issue which was encountered earlier with v1.7.0.
It has only removed redundant plugin which is getting repeated in child module (splunk). Rest all things remains as is.

[fantavlik]

Looks good, thanks for clarifying that this does not address the parent/child dependency issue from 1.7.1