Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't output close tags if you haven't written a start tag #237

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Don't output close tags if you haven't written a start tag #237

merged 3 commits into from
Jan 20, 2022

Conversation

scottsavarese
Copy link
Contributor

In looking at Splunk I found lots of events with just </stream> as the text. Looking at the code, the event_write class will always output the closing tag even if it doesn't output a start tag or any event. So, I added a check to see if there was a start tag written. If so, put a valid close tag. Otherwise, do not

@bparmar-splunk
Copy link
Contributor

bparmar-splunk commented Jan 13, 2022

Hi @scottsavarese,
Will you please re-push your changes (w. r. t. newer sdk change) along with resolved conflicts?

When your changes are pushed, it will trigger Github workflow for executing test cases. So that It will help us to troubleshoot if any issue is encountered.

@scottsavarese
Copy link
Contributor Author

@bparmar-splunk , Wow, old change. Forgot about this one. What exactly do you need me to do? Are you asking me to create a new PR for this that is more current, or simply pull the latest from the develop branch and fix any conflicts?

@scottsavarese
Copy link
Contributor Author

@bparmar-splunk , I pulled in the latest from your develop branch and fixed a merge conflict. The workflow won't start without a maintainer to kick it off. Let me know if you need me to do anything else.

@bparmar-splunk
Copy link
Contributor

bparmar-splunk commented Jan 19, 2022

Hi @scottsavarese,
We have approved workflow to execute test cases.
Test are passed with python v2, but fails with v3.
Cause of failure is due to the line which you have modified. It should be string instead of bytes w. r. t. python v3. (Please check error logs of Github CI workflow executed against python v3).

Could you please make relevant change so that it should be compatible with either of the version ?

@scottsavarese
Copy link
Contributor Author

@bparmar-splunk , I removed the bytes part of the output, but still seeing failures. They look 100% unrelated to my change. But I have no idea how to read your test results output.

@bparmar-splunk bparmar-splunk merged commit b81e081 into splunk:develop Jan 20, 2022
@scottsavarese scottsavarese deleted the develop branch January 20, 2022 12:44
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants