Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case failure for 8.0 and latest(8.2.x) splunk version #404

Merged
merged 6 commits into from
Oct 14, 2021

Conversation

akaila-splunk
Copy link
Contributor

  • replace deprecated apps/appinstall endpoint with apps/local

akaila-splunk and others added 6 commits October 8, 2021 17:56
- Replace deprecated apps/appinstall endpoint with apps/local
Passing input Kind as multiple modular inputs have "input" with name "default"
@@ -45,6 +45,12 @@ jobs:
echo password=changed! >> .splunkrc
echo scheme=https >> .splunkrc
echo version=${{ matrix.splunk }} >> .splunkrc
- name: Create build dir for ExamplesTestCase::test_build_dir_exists test case
run: |
cd ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed

Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about a line that can be removed but otherwise looks great, glad to see things all green again 🚀

@ashah-splunk ashah-splunk merged commit 7a508da into develop Oct 14, 2021
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Nov 1, 2021
@ashah-splunk ashah-splunk deleted the DVPL-10081 branch December 8, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants