Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new github_commit modular input example #426

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Added new github_commit modular input example #426

merged 2 commits into from
Jan 5, 2022

Conversation

akaila-splunk
Copy link
Contributor

  • In this PR, added a new github_commit example which includes checkpointing
  • updated docker-compose.yml file that will mount the github_commits example and splunklib directory during docker container spin up process
  • Tested working of examples on windows system for sdk version 1.6.18 and dockerized splunk version 8.0 and latest
  • Please see instructions in github_commits/README.md file for how to run example

@akaila-splunk
Added new github_commit modular input example
877fe64 
- updated docker-compose.yml file that will mount the example and splunklib directory during docker container spin up process
- added instruction in readme.md file for how to run example
fantavlik
fantavlik approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about copyright year and naming convention but in general this is working and looking good to merge, nice work!

examples/github_commits/bin/github_commits.py Outdated Show resolved Hide resolved
examples/github_commits/bin/github_commits.py Outdated Show resolved Hide resolved
@ashah-splunk ashah-splunk merged commit c8fe42c into develop Jan 5, 2022
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Merged
@akaila-splunk akaila-splunk deleted the DVPL-8272 branch May 2, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashah-splunk ashah-splunk ashah-splunk approved these changes

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akaila-splunk @fantavlik @ashah-splunk