Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace .splunkrc with .env file in test and examples #427

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Replace .splunkrc with .env file in test and examples #427

merged 3 commits into from
Feb 2, 2022

Conversation

akaila-splunk
Copy link
Contributor

  • replace .splunkrc file with .env in examples and test cases
  • updated __init _.py and cmdopts classes method to support .env file
  • created new .env file
  • updated README.md file
  • removed scripts and makefile commands use for creating .splunkrc file
  • removed .splunkrc create steps from GitHub action for test

@akaila-splunk
Replace .splunkrc with .env file in test and examples
09551a8 
- Replace .spluncrc file with .env in examples and test cases
- updated __init__.py and cmdopts classes method to support .env file
@akaila-splunk
removed .splunkrc support
fbb867c 
- Updated README.md file
- removed scripts and makefile commands use for creating .splunkrc file
- removed .splunkrc create steps from GitHub action for test
fantavlik
fantavlik requested changes Jan 19, 2022
View reviewed changes
README.md Show resolved Hide resolved
scripts/build-splunkrc.py Show resolved Hide resolved
fantavlik
fantavlik approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! This is working for me locally as well

@ashah-splunk ashah-splunk merged commit 41ae251 into develop Feb 2, 2022
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Merged
@akaila-splunk akaila-splunk deleted the DVPL-8563 branch May 2, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akaila-splunk @fantavlik @ashah-splunk