Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional retries feature added #442

Merged
merged 12 commits into from
Apr 20, 2022
Merged

Optional retries feature added #442

merged 12 commits into from
Apr 20, 2022

Conversation

ashah-splunk
Copy link
Contributor

  • Added optional retries feature provided by user in PR
  • Added test case for the optional retries
  • Added example for the optional retries
  • Added optional retry parameter for existing test cases setup, to prevent CI build failures

fantavlik
fantavlik reviewed Apr 19, 2022
View reviewed changes
splunklib/binding.py Outdated Show resolved Hide resolved
fantavlik
fantavlik approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about calling out that this is blocking/synchronous but in general this looks good!

@ashah-splunk
Update binding.py
7acd49a 
Updated the comment to specify this works in synchronous/blocking way
@ashah-splunk ashah-splunk merged commit 8881cd8 into develop Apr 20, 2022
@ashah-splunk ashah-splunk deleted the optional-retry branch May 2, 2022 06:57
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashah-splunk @fantavlik @mew1033